Login fix, reply webview hack, bypass age verification, and fixes#90
Open
theacrat wants to merge 54 commits into
Open
Login fix, reply webview hack, bypass age verification, and fixes#90theacrat wants to merge 54 commits into
theacrat wants to merge 54 commits into
Conversation
Set textContentType (username / password) on the xAuth login fields so iOS recognises the form and offers saved logins and the Passwords key in the QuickType bar — the native equivalent of tagging a web form's inputs with autocomplete=username / current-password.
…#4) The composer's Post button disappeared whenever "Hide Grok analyze buttons" was on, making posting impossible (#2). BHTRemoveGrokBarButtonItems matched every UIBarButtonItem with a nil accessibilityLabel: [nil rangeOfString:@"grok"] .location is 0 (a zeroed NSRange from messaging nil), which is != NSNotFound, so unlabeled bar buttons — the Post button included — were deleted. Guard for a non-nil label before matching. Also replace the over-broad TFNButton didMoveToWindow Grok heuristic (it hid any unlabeled nav-bar button that had a menu — the Post button is exactly that) with positive identification: hide only TFNButtons whose primary-action menu contains a Grok item ("Analyse with Grok" / "Open in Grok"). Other broken toggles: - restore_follow_button ("No Subscribe button"): drop the unconditional -[TUIFollowControl variant] override that returned 32 for every read, which hid the Follow button on every tweet. The setVariant: remap already converts Subscribe (1) -> Follow (32). - hidePremiumOffer ("No Twitter Blue prompts"): read the pref instead of a hardcoded `return YES` (the toggle was stuck on). - DisableVODCaptions ("No video captions"): read the key the settings UI writes (video_layer_caption) instead of an unexposed dis_VODCaptions (toggle was dead). - refresh_pill_label: scope the "Tweeted" relabel to the new-posts pill instead of overriding every TFNPillControl's text. Co-authored-by: thea <git@thea.pet>
New Tweets setting (hide_downvote_button, default off) that removes the downvote/dislike button X shows on replies. The button (TTAStatusInlineDownvoteButton, in TwitterAppSPMMigration) is created unconditionally and its display is driven at layout time by its -visibility property: TTAStatusInlineActionsView lays out only buttons whose visibility is non-zero and hides the rest. Filtering the inline-action class list (and forcing the +t1_shouldShowDownvoteButtonForViewModel… gate to NO) was not enough on its own because the button is still instantiated, so the decisive fix overrides -[TTAStatusInlineDownvoteButton visibility] to return 0 when the toggle is on — excluding it from layout with no gap. The class-list filter and gate override are kept as upstream defense-in-depth. Localized in all bundled languages.
Author
|
I've stopped updating this branch because I've done a large refactor to organise things in my v6 branch. You're free to take that as well of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on X 11.99.
High chance some of these changes are unnecessarily complex with fallbacks and stuff as I got sick of trial and erroring every single flow.
Example built IPA here: https://github.com/theacrat/NeoFreeBird/releases